Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edge-case where Texture#toString has a NullPointer because gson s… #838

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Fix edge-case where Texture#toString has a NullPointer because gson s… #838

merged 2 commits into from
Jul 18, 2024

Conversation

AlexProgrammerDE
Copy link
Contributor

…et a null metadata

Also changes NORMAL name to WIDE since that's the accurate name used inside the mc client.

@AlexProgrammerDE
Fix edge-case where Texture#toString has a NullPointer because gson s…
b452c31 
…et a null metadata

Also changes NORMAL name to WIDE since that's the accurate name.
@AlexProgrammerDE
Copy link
Contributor Author

Mojang AuthLib has similar code:
image

@AlexProgrammerDE
Copy link
Contributor Author

Also fixes now #837

onebeastchris
onebeastchris approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@onebeastchris onebeastchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onebeastchris onebeastchris merged commit 05a699d into GeyserMC:master Jul 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onebeastchris onebeastchris onebeastchris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexProgrammerDE @onebeastchris